Optimize pop to reduce interleaved layout writes
#152
+17
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rortan134 is attempting to deploy a commit to the Barvian Team on Vercel. A member of the Team first needs to authorize it. |
rortan134
changed the title
pop to reduce interleaved layout writes
Owner
|
Hey, thanks a lot for the PR! I acknowledge there's definitely layout thrashing happening in the current implementation and am working to resolve it at a higher level. Not sure if I'll incorporate this into that work yet, just thought I'd let you know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Previously this method interleaved layout reads (e.g., offsetTop) and writes (e.g., style updates) in a loop, forcing multiple browser reflows per character (O(n) layout calculations. Forced reflows: now O(1) instead of O(n))