-
Notifications
You must be signed in to change notification settings - Fork 125
feat: Add support for ERC-8132: Gas Limit Override Capability #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ajhodges
wants to merge
8
commits into
base:master
Choose a base branch
from
ajhodges:erc-8132
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
14792ea
feat: Add support for ERC-8132: Gas Limit Override Capability
ajhodges b8c1dd5
fix
ajhodges 32e1e6c
remove max gas limit check
ajhodges fd1105e
feat: aggregate per-call gasLimitOverride in routeThroughGlobalAccount
ajhodges 9b83c8e
fix: add ts-ignore for test mock type assertions
ajhodges db445da
fix: align batch overhead with backend buffer params
ajhodges ee945a5
fix: deep-merge 0x0 capabilities to preserve gasLimitOverride
ajhodges f9d4653
refactor: extract ALL_CHAINS_KEY constant for 0x0 wildcard
ajhodges File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import { Hex } from 'viem'; | ||
|
|
||
| export type GasLimitOverrideCallCapability = { | ||
| value: Hex; | ||
| }; | ||
|
|
||
| export type GasLimitOverrideCapability = { | ||
| supported: boolean; | ||
| }; | ||
|
|
||
| export type CallCapabilities = { | ||
| gasLimitOverride?: GasLimitOverrideCallCapability; | ||
| [key: string]: unknown; | ||
| }; | ||
|
|
||
| export type WalletSendCallsCall = { | ||
| to: Hex; | ||
| data?: Hex; | ||
| value?: Hex; | ||
| capabilities?: CallCapabilities; | ||
| }; | ||
|
|
||
| export type WalletSendCallsParams = [ | ||
| { | ||
| version: string; | ||
| chainId: Hex; | ||
| from: Hex; | ||
| calls: WalletSendCallsCall[]; | ||
| atomicRequired?: boolean; | ||
| capabilities?: Record<string, unknown>; | ||
| }, | ||
| ]; | ||
|
|
||
| export type WalletSendCallsSchema = { | ||
| Method: 'wallet_sendCalls'; | ||
| Parameters: WalletSendCallsParams; | ||
| ReturnType: Hex; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.