-
Notifications
You must be signed in to change notification settings - Fork 318
incident multisig signers template #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leopoldjoy
wants to merge
10
commits into
base:main
Choose a base branch
from
leopoldjoy:feat/update-incident-multisig-signers-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
incident multisig signers template #493
leopoldjoy
wants to merge
10
commits into
base:main
from
leopoldjoy:feat/update-incident-multisig-signers-template
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it to replace the outdated safe-management template
… the EXISTING_OWNERS_LENGTH env var should contain
Collaborator
🟡 Heimdall Review Status
|
xenoliss
reviewed
Nov 3, 2025
setup-templates/template-incident-multisig-signers/script/UpdateSigners.s.sol
Outdated
Show resolved
Hide resolved
jackchuma
reviewed
Nov 17, 2025
Contributor
jackchuma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for any multisig, not necessarily just the "incident" multisig. I think the previous template-safe-management is a name we should stick with
…ub.com:leopoldjoy/contract-deployments into feat/update-incident-multisig-signers-template
jackchuma
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a template for incident multisig signers updates, based off of this previously executed task. It also removes the existing safe-management task template in order to prevent fragmentation of the same task functionality and also because the safe-management task template only allowed single owner swaps (thus more limited functionality).
This new template also employs the new Signer Tool for streamlining the signing process.