-
Notifications
You must be signed in to change notification settings - Fork 318
feat(sepolia): set the Jovian parameters on Base Sepolia #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This task sets the Jovian hardfork parameters on Base Sepolia's SystemConfig: - setDAFootprintGasScalar(260) - Sets DA footprint gas scalar - setMinBaseFee(5000000) - Sets minimum base fee to 5M wei These parameters activate with the Jovian hardfork.
Adds gen-validation target to Makefile for generating VALIDATION.md automatically once the Jovian upgrade is deployed to Base Sepolia. VALIDATION.md currently contains only a comment explaining it cannot be generated yet because the setDAFootprintGasScalar and setMinBaseFee functions don't exist on the current SystemConfig deployment. Once the Jovian upgrade is deployed, run `make gen-validation` to generate the full validation file with state-diff.
Updates DA_FOOTPRINT_GAS_SCALAR from 260 to 325 based on the formula: da_footprint_gas_scalar = gas_target / (l1_target_throughput * estimation_ratio) Where: - l1_target_throughput = (blob_count * 128,000 bytes/blob) / 12 sec/block - gas_target = 31.25 Mgas/sec - blob_count = 6 blobs/block - estimation_ratio = 1.5 Calculation: l1_target_throughput = (6 * 128,000) / 12 = 64,000 gas/sec da_footprint_gas_scalar = 31,250,000 / (64,000 * 1.5) = 325.52 ≈ 325
Updates the minimum base fee from 5,000,000 wei to 10,000 wei (1e-5 gwei). This is a placeholder value that will be updated on November 14 to reflect the previous week's p10-p20 base fee.
…ss from the sepolia/2025-11-07-upgrade-fault-proofs task
✅ Heimdall Review Status
|
jackchuma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. A few other nits not mentioned in other comments:
- Can you add a
FACILITATORS.mdfile similar to other recent tasks? - Can you also update the root
Makefilewith the latest task signer tool commit hash (abbfa09210582eca32ad4873d862994a5957fbc2) - Can you run
forge fmtin the task directory with the latest stable foundry release?
sepolia/2025-11-18-set-jovian-parameters/validations/op-signer.json
Outdated
Show resolved
Hide resolved
sepolia/2025-11-18-set-jovian-parameters/validations/cb-signer.json
Outdated
Show resolved
Hide resolved
sepolia/2025-11-18-set-jovian-parameters/validations/cb-sc-signer.json
Outdated
Show resolved
Hide resolved
sepolia/2025-11-18-set-jovian-parameters/script/SetJovianParameters.s.sol
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,19 @@ | |||
| # Base Contracts commit | |||
| BASE_CONTRACTS_COMMIT=51788f920e368e72c63cef24a5e1ea0f6562d9a5 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this is the latest Base contracts commit hash
| BASE_CONTRACTS_COMMIT=51788f920e368e72c63cef24a5e1ea0f6562d9a5 | ||
|
|
||
| # Optimism commit (op-contracts/v5.0.0) | ||
| OP_COMMIT=d09c836f818c73ae139f60b717654c4e53712743 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this is the correct OP commit hash
This task sets the minimum base fee to 200,000 wei (2e-4 gwei) and the DA footprint scalar to 312. These are the values we intend to use on Base Mainnet as well.
200,000 wei was chosen based on the p5 base fee observed on Base Mainnet from November 7 to 14 and rounded down slightly to get a nice number. The DA footprint was calculated from
da_footprint_gas_scalar = block_gas_target_throughput / (blob_target * 128,000 bytes / 12 seconds * estimation_ratio)whereblock_gas_target_throughput = 30,000,000 gas/sec,blob_target = 6, andestimation_ratio = 1.5.30,000,000 / (6 * 128,000 / 12 * 1.5) = 312.5, which was rounded down to the nearest integer.The task uses the
OWNER_SAFEhierarchy from thesepolia/2025-11-07-upgrade-fault-proofstask. This differs from SystemConfig parameter changes on Base Mainnet, which do not use the nested safes.