[Feature] Preserve kamal default options #1427
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add check for default options from `.kamal/options.yml` file. - Add `config_file` option check, with backward-compatible fallback to `config/deploy.yml` value. - Add `.kamal/options.yml` creation on `kamal init` command. Existing option `-c` can be used during initialization to provide default config file. It will be stored into `.kamal/options.yml`. If not provided, backward-compatible `config/deploy.yml` will be stored. - Cover `.kamal/options.yml` with tests. Note: Changes preserve backward-compatibility with current behavior. This feature is extension without breaking stuff.
|
This is would also be very useful when using a project that has a "config" file like radicale for example. |
Contributor
Author
|
@djmb, Do you have this idea in consideration? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
.kamal/options.ymlfile as storage for default options used with kamal commands.It implements proposal-issue to set default deploy config file with different location. To eliminate necessity applying option with each kamal command, like
kamal deploy -c .kamal/deploy.yml, or with often run manually alias-commands.Closes #1424
This foundation should be easily applicable for other options. E.g. to allow
destinationdefault from.kamal/options.ymlfile, change should be as minimal as following:Changes
.kamal/options.ymlfile.config_fileoption check, with backward-compatible fallback toconfig/deploy.ymlvalue..kamal/options.ymlcreation onkamal initcommand. Existing option-ccan be used during initialization to provide default config file. It will be stored into.kamal/options.yml. If not provided, backward-compatibleconfig/deploy.ymlwill be stored..kamal/options.ymlwith tests.Note: This PR preserves backward-compatibility with current behavior. This feature is extension without breaking stuff.