fix cli args causing null values in config#34
Draft
justus237 wants to merge 3 commits intobastian-src:mainfrom
Draft
fix cli args causing null values in config#34justus237 wants to merge 3 commits intobastian-src:mainfrom
justus237 wants to merge 3 commits intobastian-src:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When passing CLI arguments that set the value of an inner field of a nested struct, currently, all other fields of that struct also need to be set using CLI arguments, otherwise the field values will be
null.Also, since afaict,
print_debugdoesn't work inparse.rsdue to how everything is initialized, all prints were changed toprint_infoand will be printed every time.Not sure about URI paths, I think they were not "pbe" anymore but "l2b" in the current server/tocket, so this would also be fixed.
All default values are at the top now as const.