You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR introduces rhythmic expression tools to the WaveBard sample player by adding Swing and Humanize functionalities. A new control is mapped to the Settings layer (Pot 6), allowing users to either delay even steps for a rhythmic swing (55%–100% range) or apply pseudo-random timing offsets using a predefined pattern to simulate natural playing imperfections (0%–45% range). The implementation includes an updated trigger mechanism in the AudioLoop to handle clock-based delays and provides visual feedback via LED 1, which changes color to indicate the active mode. Additionally, the AppWaveBard class has been expanded with the necessary state variables and logic to manage these delayed trigger events seamlessly.
Hi, I tested it, seems to work fine! But I have few suggestions:
"Advanced Settings" isn't really good place for that since it breaks the workflow, you can't really adjust it on the fly nicely. I'd recommend moving it into the "Mode" layer, that can be easily controlled by holding MODE/BANK button. Also I'd recommend moving it into the Pot 7, since the swing is related to the tempo. That way the LFO LED can be reused for that.
I would highly suggest moving it to the "output side", basically modifying the Sequencer class with swing option (affecting both CV and GATE). That would allow this feature to be used for all patch inputs and with all firmwares, since MODE + TEMPO pot isn't used anywhere else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces rhythmic expression tools to the WaveBard sample player by adding Swing and Humanize functionalities. A new control is mapped to the Settings layer (Pot 6), allowing users to either delay even steps for a rhythmic swing (55%–100% range) or apply pseudo-random timing offsets using a predefined pattern to simulate natural playing imperfections (0%–45% range). The implementation includes an updated trigger mechanism in the AudioLoop to handle clock-based delays and provides visual feedback via LED 1, which changes color to indicate the active mode. Additionally, the AppWaveBard class has been expanded with the necessary state variables and logic to manage these delayed trigger events seamlessly.