Osaka mostly working for Mavericks. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 24, 2014 10:56
…s, pages UTs and ITs have some failures
…s, pages UTs and ITs have some failures, and fixed a comment.
…me deprication warnings, more to do
Owner
There was a problem hiding this comment.
Usually in higher-level classes, we wouldn't want to use the CommandRunner ? Is it possible to wrap that into a higher level to keep the abstraction good?
Owner
|
James. There is a lot of changes. It would be good to try to do them in smaller pull requests. E.g. first the deprecation ones related rspec and other small ones, so that it is easier to review the real changes. Do you think that is possible? I made some comments above already... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Osaka mostly working for Mavericks. Things TBD:
keynote print control
pages UTs and ITs have some failures
make deprecated rspec warnings go away
--- Bas, can you please look over my changes and give me some pointers on better ways to do some of this.
I added a run_all_test.sh script to cover for my lack of rake knowledge. I ran the script on my :mavericks and :lion machines. I have assest files for old and new keynote format. The file change count here is rather inflated due to the new keynote files/dir structure.