fix: keep original header file layout when symlink into ext_include_dir#1266
Open
gulu-goolu wants to merge 2 commits intobazel-contrib:mainfrom
Open
fix: keep original header file layout when symlink into ext_include_dir#1266gulu-goolu wants to merge 2 commits intobazel-contrib:mainfrom
gulu-goolu wants to merge 2 commits intobazel-contrib:mainfrom
Conversation
gulu-goolu
changed the title
gulu-goolu
force-pushed
the
gulu-goolu-patch-2
branch
from
955882a to
e283961
Compare
jsharpe
reviewed
Mar 7, 2025
| return file if type(file) == "string" else file.path | ||
|
|
||
| def _get_dir_name(dir, file): | ||
| if dir == "include": |
Member
There was a problem hiding this comment.
Don't we always want to do this? Surely if it was linking say share/ into the tree you'd also want the folder structure to be maintained?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr attempt to fix when building a cmake target which depends a cc_library target, the
@rules_foreign_ccdoesn't keep original header file layout of cc_library. for example, if a cmake target depends@com_google_absl//absl/base，current version of@rules_foreign_cwill create symlinks of like$EXT_BUILD_DEPS/include/attributes.h, instead of$EXT_BUILDS_DEPS/include/absl/base/attributes.h