meson: add a shared_ldflags_option attr#1401
Open
matt-sm wants to merge 2 commits intobazel-contrib:mainfrom
Open
meson: add a shared_ldflags_option attr#1401matt-sm wants to merge 2 commits intobazel-contrib:mainfrom
matt-sm wants to merge 2 commits intobazel-contrib:mainfrom
Conversation
matt-sm
force-pushed
the
meson-ldflags
branch
6 times, most recently
from
5870486 to
9462307
Compare
matt-sm
force-pushed
the
meson-ldflags
branch
3 times, most recently
from
c094ca7 to
c991b44
Compare
matt-sm
changed the title
matt-sm
changed the title
matt-sm
force-pushed
the
meson-ldflags
branch
from
6aca9fc to
e36c11b
Compare
matt-sm
force-pushed
the
meson-ldflags
branch
from
502fd8f to
e36c11b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the meson rule will always set LDFLAGS to
flags.cxx_linker_executable.If there are any executable-specific flags eg.
-piein that list, any mesonshared_library()will fail to link.Cmake has a feature whereby you can set target-specific linker flags eg.
CMAKE_CXX_LINK_EXECUTABLE. Meson does not have a similar concept: upstream issueAs a workaround, this MR adds a new
shared_ldflags_optionattribute to themesonrule that will add shared flags to a build option with the specified name. This attribute follows themakeshared_ldflags_varspattern.Additional change: the
optionsvalues are not currently expanded. This PR also adds location expansion to this attr.