Add BazelDebugFlagsBuilder #8021
Open
+131
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeFrosch
force-pushed
the
pull/7f975bb3f99b2f6ba1b664b42f93933a45b2bd5b
branch
from
7f975bb to
a64dcbc
Compare
github-actions
bot
added
product: CLion
ujohnny
requested changes
Dec 3, 2025
| compilerKind, | ||
| OS.CURRENT, | ||
| withClangTrimPaths = Registry.`is`("bazel.trim.absolute.path.disabled"), | ||
| withFissionFlag = Registry.`is`("bazel.clwb.debug.fission.disabled"), |
Collaborator
There was a problem hiding this comment.
I guess we have to have ! here as then
&& withFissionFlag) {
switchBuilder.withSwitch("--fission=yes")
}
ujohnny
reviewed
Dec 3, 2025
| } | ||
| } | ||
|
|
||
| fun withTestFlags(timeout: Int? = 3600) { |
Collaborator
There was a problem hiding this comment.
60.minutes and later toSeconds()
ujohnny
reviewed
Dec 3, 2025
| */ | ||
| class BazelDebugFlagsBuilder( | ||
| private val debuggerKind: BlazeDebuggerKind, | ||
| private val compilerKind: OCCompilerKind, |
Collaborator
There was a problem hiding this comment.
some compilerkind/debuggerkind combinations do not make any sense, do we want to enforce some checks here or around?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup for: #7825, #7639 and #7827
Introduces a common flag builder for assembling all flags required for debug builds / runs. In theory we would like a builder that creates
BlazeCommandand hands this off the theBazelExecServiceto have full control over the environment, but this would be a major refactor.