Skip to content
This repository was archived by the owner on Dec 15, 2023. It is now read-only.

Conversation

@jiaqi
Copy link
Contributor

@jiaqi jiaqi commented Feb 27, 2020

Before

#112
#111
To demonstrate the problem this PR added a static.txt file to the example appengine_war target. With the original code

  • The static.txt file was added to the root of the war, which means if there's another file named static.txt under another location, they would conflict and only one will stay in the war file.
  • The static.txt file does not exist in webapp root directory, bazel-out/darwin-fastbuild/bin/examples/java/examples.runfiles/io_bazel_rules_appengine/examples/java/webapp

After
With the same example,

  • The static.txt file is added to war as examples/java/static.txt.
  • At runtime, the static.txt file is linked from bazel-out/darwin-fastbuild/bin/examples/java/examples.runfiles/io_bazel_rules_appengine/examples/java/webapp/examples/java/static.txt

@jiaqi jiaqi requested a review from pmbethe09 as a code owner February 27, 2020 06:24
@jiaqi jiaqi closed this Feb 27, 2020
@jiaqi jiaqi reopened this Feb 27, 2020
@pmbethe09 pmbethe09 self-assigned this Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants