Enhance mobile responsiveness for edit group#1355
Open
Conversation
eed5c75 to
11670f2
Compare
f5d5cd2 to
5db4919
Compare
Collaborator
Author
|
MrDirkelz
reviewed
Mar 16, 2026
Collaborator
There was a problem hiding this comment.
This looks good!
Check if you can use LDropdown for AddGroupAclButton?
The ui looks nice and compact and easy to understand!
Great work!
(Just check the failing test)
Also check that all shared components did not have any side-effects on any other components? Seems the tests are failing for other components for where you made the changes.
Remember to rebase as well
28f49a9 to
4fcb9df
Compare
Collaborator
|
…ode with a sticky options in LModal
9336c3a to
a69a326
Compare
MrDirkelz
approved these changes
Mar 26, 2026
Collaborator
MrDirkelz
left a comment
There was a problem hiding this comment.
Just some comments before merging.
Remove bottom margin on duplicate button in EditGroup.vue. Also do a quick check if you can make the addgroupaclbutton's combobox input a tiny bit more compact or smaller. Don't spend too much time on this, it can always be refined in a new ticket.
Good work.
| :show-selected-in-dropdown="false" | ||
| :showSelectedLabels="false" | ||
| :icon="UserGroupIcon" | ||
| disable-teleport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Editin the titleunsaved changesbadge on the display cards in the overviewadd / removebuttonDiscard changesbutton and theUnsaved changesbutton at the top of the dialogDuplicatebutton at the bottom left of the modalDiscard changes( to revert + icon) andDuplicate( add text ) buttonsAdd accessshould be a plus button