Skip to content

Enhance mobile responsiveness for edit group#1355

Open
ChrisTouo wants to merge 26 commits intomainfrom
1350-cms-make-edit-group-mobile-friendly
Open

Enhance mobile responsiveness for edit group#1355
ChrisTouo wants to merge 26 commits intomainfrom
1350-cms-make-edit-group-mobile-friendly

Conversation

@ChrisTouo
Copy link
Collaborator

@ChrisTouo ChrisTouo commented Feb 25, 2026

  • move the text in the overview
  • Align buttons in LDialog
  • Remove Copy ID button and the icon and Edit in the title
  • Add a close button at the top right of the dialog
  • Add the unsaved changes badge on the display cards in the overview
  • Remove the small bars on the edges in the displayCard in the dialog
  • Add arrows if there is more content scrollable
  • Make the content fit for the modal with a min heigth
  • Remove the exclammation mark on the texts and the Icon on the add / remove button
  • Move the Discard changes button and the Unsaved changes button at the top of the dialog
  • Move the Duplicate button at the bottom left of the modal
  • Remove the white background in the dialog
  • Improve Discard changes ( to revert + icon) and Duplicate ( add text ) buttons
  • Remove the Cancel button, not needed anymore
  • Add access should be a plus button
  • Display the group Editor name in the modal
  • Display the disclosure button on the same line with the title
  • Modify the text in the overview
  • Move the plus button
  • Add the root guard
  • Automatic scroll

@ChrisTouo ChrisTouo linked an issue Feb 25, 2026 that may be closed by this pull request
@ChrisTouo ChrisTouo force-pushed the 1350-cms-make-edit-group-mobile-friendly branch from eed5c75 to 11670f2 Compare March 6, 2026 06:23
@ChrisTouo ChrisTouo force-pushed the 1350-cms-make-edit-group-mobile-friendly branch from f5d5cd2 to 5db4919 Compare March 11, 2026 22:15
@ChrisTouo
Copy link
Collaborator Author

ChrisTouo commented Mar 13, 2026

  • Buttons too dark
  • Modify the position of the title
  • Make the same view on desktop mode
  • Check the paddings on buttons in the table
  • Put edit/remove button instead of edit

Copy link
Collaborator

@MrDirkelz MrDirkelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

Check if you can use LDropdown for AddGroupAclButton?

The ui looks nice and compact and easy to understand!

Great work!

(Just check the failing test)
Also check that all shared components did not have any side-effects on any other components? Seems the tests are failing for other components for where you made the changes.

Remember to rebase as well

@ChrisTouo ChrisTouo force-pushed the 1350-cms-make-edit-group-mobile-friendly branch 3 times, most recently from 28f49a9 to 4fcb9df Compare March 20, 2026 07:39
@MrDirkelz
Copy link
Collaborator

MrDirkelz commented Mar 20, 2026

  • Add helper text "Super Admins have this access to public users:" on group access modal
  • When clicking plus icon there implement expanded combobox
  • Bleed modals to the edges
  • Ensure user has assign access to be able to add group assign access
  • The margins of the headings must be consistent with other margins

Copy link
Collaborator

@MrDirkelz MrDirkelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image Squashy modal

Test failing.

But past that looks nice!

@ChrisTouo ChrisTouo force-pushed the 1350-cms-make-edit-group-mobile-friendly branch from 9336c3a to a69a326 Compare March 23, 2026 11:41
Copy link
Collaborator

@MrDirkelz MrDirkelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments before merging.

Remove bottom margin on duplicate button in EditGroup.vue. Also do a quick check if you can make the addgroupaclbutton's combobox input a tiny bit more compact or smaller. Don't spend too much time on this, it can always be refined in a new ticket.

Good work.

:show-selected-in-dropdown="false"
:showSelectedLabels="false"
:icon="UserGroupIcon"
disable-teleport
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused prop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMS: Make Edit Group mobile friendly

2 participants