Cannot open Mobile Sidebar from Group Overview (#1340)#1359
Open
Cannot open Mobile Sidebar from Group Overview (#1340)#1359
Conversation
Comment on lines
+85
to
+96
|
|
||
| const props = defineProps<{ onOpenMobileSidebar?: () => void }>(); | ||
| </script> | ||
|
|
||
| <template> | ||
| <div> | ||
| <BasePage title="Groups" :is-full-width="true" :loading="isLoading"> | ||
| <BasePage | ||
| title="Groups" | ||
| :is-full-width="true" | ||
| :loading="isLoading" | ||
| :onOpenMobileSidebar="props.onOpenMobileSidebar" | ||
| > |
Contributor
There was a problem hiding this comment.
Understand the fix is working, but we need to understand why the bug is occuring in the first place, and why this fix is solving it. The fix looks like it does nothing, and will not be understood by a maintainer looking at the code in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1340