Configurable repo #63
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made changes to make the crunchy repos more configurable. Updated the README. We can create the schedule in the values.yaml file allowing us to dynamically add repos with: name path volume s3 schedules
jasonchung1871
had a problem deploying
to
tools
GitHub Actions
Failure
jasonchung1871
had a problem deploying
to
tools
GitHub Actions
Failure
jasonchung1871
commented
Dec 30, 2024
| {{ if .Values.postGISVersion }} | ||
| postGISVersion: {{ .Values.postGISVersion | quote }} | ||
| {{ end }} | ||
| postgresVersion: {{ .Values.postgresVersion }} |
Author
There was a problem hiding this comment.
Duplicate postgresVersion
jasonchung1871
commented
Dec 30, 2024
| repo2-s3-uri-style: {{ .Values.pgBackRest.s3.s3UriStyle }} | ||
| {{- end }} | ||
| {{ range $repo := .Values.pgBackRest.repos }} | ||
| {{ if eq $.Values.pgBackRest.s3.enabled true }} |
Author
There was a problem hiding this comment.
This could probably be changed to check if the s3 key exists, using this check for the bucket path, also did not want to change the other uses of s3.enabled
Removed app specific values
jasonchung1871
had a problem deploying
to
tools
GitHub Actions
Failure
jasonchung1871
had a problem deploying
to
tools
GitHub Actions
Failure
Author
|
@caggles this is currently working in our namespace! i'm just looking into porting over our data from an older postgres database into the crunchy database now. |
jasonchung1871
had a problem deploying
to
tools
GitHub Actions
Failure
jasonchung1871
had a problem deploying
to
tools
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to make the crunchy repos more configurable and updated the README.
We can create the schedule in the values.yaml file allowing us to dynamically add repos with: name
path
volume
s3
schedules