Fix build system, and add input from hex.#3
Open
EvanCarroll wants to merge 5 commits intobeargiles:masterfrom
Open
Fix build system, and add input from hex.#3EvanCarroll wants to merge 5 commits intobeargiles:masterfrom
EvanCarroll wants to merge 5 commits intobeargiles:masterfrom
Conversation
* The build system previously was broke, files were attempting to be copied twice fouling make. See issue beargiles#2 on github. * We didn't currently have a method of converting hex to bignum, added. * Also fixed freeing in the event of length mismatch, believe this was a memory leak.
* this works with b16 and b10 * maintained hex2bn binding so we don't have to add 0x to cstring input to get a bn.
|
LGTM. |
addition of bn_out_hex function.
Author
|
Can we commit this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build system previously was broke, files were attempting to be
copied twice fouling make. See issue Make system is broke. #2 on github.
We didn't currently have a method of converting hex to bignum, added.
Also fixed freeing in the event of length mismatch, believe this was a
memory leak.
Changed the default previously for _in which was cstring->bignum but dec specific to provide for hex if prefix with 0x was detected by using asc2bn internally. Basically a copy of @BenBE's add: Support hex notation by 0xabcd when converting to bignum values #1