Skip to content

dpctl queue-get-config showing only 1 queue #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikchez01 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

dpctl queue-get-config showing only 1 queue #51

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b4aa40
dpctl queue-get-config showing only 1 queue
nikchez01 Jun 1, 2017
125831f
Update ofl-messages-unpack.c
nikchez01 Jun 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion oflib/ofl-messages-unpack.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1591,6 +1591,7 @@ ofl_msg_unpack_queue_get_config_reply(struct ofp_header const *src, size_t *len,
struct ofp_packet_queue *queue;
ofl_err error;
size_t i;
size_t len1=0,len2=0;

if (*len < sizeof(struct ofp_queue_get_config_reply)) {
OFL_LOG_WARN(LOG_MODULE, "Received GET_CONFIG_REPLY has invalid length (%zu).", *len);
Expand All @@ -1612,13 +1613,18 @@ ofl_msg_unpack_queue_get_config_reply(struct ofp_header const *src, size_t *len,

queue = sr->queues;
for (i = 0; i < dr->queues_num; i++) {
error = ofl_structs_packet_queue_unpack(queue, len, &(dr->queues[i]));
/* This is so that it can parse packet with more than 1 queue.
* Previously, dpctl was showing only 1 queue even if more than 1 queues are configured. */
len1=*len-(sizeof(struct ofp_packet_queue)+sizeof(struct ofp_queue_prop_min_rate))*((int)dr->queues_num-1-i);
len2=*len-(sizeof(struct ofp_packet_queue)+sizeof(struct ofp_queue_prop_min_rate))*((int)dr->queues_num-1-i);
error = ofl_structs_packet_queue_unpack(queue, &len1, &(dr->queues[i]));
if (error) {
OFL_UTILS_FREE_ARR_FUN(dr->queues, i,
ofl_structs_free_packet_queue);
free (dr);
return error;
}
*len-=len2-len1; //This is so that it can parse packet with more than 1 queue.
queue = (struct ofp_packet_queue *)((uint8_t *)queue + ntohs(queue->len));
}

Expand Down