Fix bug for multiple types in simpleFormUIFactory#6
Open
thothal wants to merge 1 commit intobeerda:masterfrom
Open
Fix bug for multiple types in simpleFormUIFactory#6thothal wants to merge 1 commit intobeerda:masterfrom
thothal wants to merge 1 commit intobeerda:masterfrom
Conversation
`attributeType` assigns **all** classes of an object to the `type` slot. In the case of an ordered factor it stores thus `factor` **and** `ordered`. In `simpleFormUIFactory` we are testing for the type via `==´. As of `R 4.2.0` using conditions of length greater than 1 will throw an error (used to be a warning before). That is, if we have any object with severeal classes (for instance an `ordered` factor), the use of `==` will cause an error. An easy fix is to replace `==` by `%in%` to make sure that the condition will always be of length one. This closes beerda#5.
Neo005
reviewed
Jan 15, 2023
Neo005
left a comment
Neo005
left a comment
There was a problem hiding this comment.
Please release the updated version of the package for R 4.2.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attributeTypeassigns all classes of an object to thetypeslot. In the case of an ordered factor it stores thusfactorandordered. InsimpleFormUIFactorywe are testing for the type via==. As ofR 4.2.0using conditions of length greater than 1 will throw an error (used to be a warning before). That is, if we have any object with severeal classes (for instance anorderedfactor), the use of==will cause an error.An easy fix is to replace
==by%in%to make sure that the condition will always be of length one.This closes #5.