Skip to content

Update imports to be compatible with the latest version of ddtrace #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update imports to be compatible with the latest version of ddtrace #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ddtrace_graphql/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"""


from ddtrace.contrib.util import require_modules
from ddtrace.contrib import require_modules

required_modules = ['graphql']

Expand Down
8 changes: 4 additions & 4 deletions ddtrace_graphql/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import ddtrace
import graphql
from ddtrace.ext import errors as ddtrace_errors
from ddtrace.constants import ERROR_MSG, ERROR_STACK, ERROR_TYPE

from ddtrace_graphql import utils

Expand Down Expand Up @@ -79,13 +79,13 @@ def traced_graphql_wrapped(
ERRORS,
utils.format_errors(result.errors))
span.set_tag(
ddtrace_errors.ERROR_STACK,
ERROR_STACK,
utils.format_errors_traceback(result.errors))
span.set_tag(
ddtrace_errors.ERROR_MSG,
ERROR_MSG,
utils.format_errors_msg(result.errors))
span.set_tag(
ddtrace_errors.ERROR_TYPE,
ERROR_TYPE,
utils.format_errors_type(result.errors))

span.error = int(utils.is_server_error(
Expand Down
3 changes: 1 addition & 2 deletions ddtrace_graphql/patch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@
import os

import graphql
import graphql.backend.core
import wrapt
from ddtrace.util import unwrap
from ddtrace.internal.utils.wrappers import unwrap

from ddtrace_graphql.base import traced_graphql_wrapped

Expand Down