Skip to content

Move away from EOL Java8, to Java 11 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janhoy wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Move away from EOL Java8, to Java 11 #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77c6511
Move away from EOL java 8 and use Java 11.
janhoy Jan 5, 2023
e2e5157
Use List.of()
janhoy Jan 5, 2023
252df29
Remove Java8 from Github Actions
janhoy Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

strategy:
matrix:
java: [ '1.8', '11', '17' ]
java: [ '11', '17' ]

name: Java ${{ matrix.java }} NoCommons
steps:
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,8 @@

<properties>
<!-- Dependency version -->
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>11</maven.compiler.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>

Expand Down
3 changes: 1 addition & 2 deletions src/test/java/no/bekk/bekkopen/mail/MailValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;

import java.util.Arrays;
import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;
Expand All @@ -22,7 +21,7 @@
public class MailValidatorTest {
private static final Poststed HAMAR = new Poststed("Hamar");

private static final List<PostInfo> postInfo = Arrays.asList(
private static final List<PostInfo> postInfo = List.of(
new PostInfo(
new Postnummer("4633"),
new Poststed("KRISTIANSAND S"),
Expand Down