Skip to content

perf: use Stack.Peek to reduce Pop and Push churn #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: use Stack.Peek to reduce Pop and Push churn #1708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Src/CSharpier.Core/DocPrinter/PropagateBreaks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using System.Runtime.CompilerServices;
using CSharpier.Core.DocTypes;

namespace CSharpier.Core.DocPrinter;
Expand Down Expand Up @@ -27,6 +28,7 @@ void BreakParentGroup()
}
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
bool OnEnter(Doc doc)
{
if (doc is ForceFlat)
Expand Down Expand Up @@ -87,22 +89,23 @@ void OnExit(Doc doc)
docsStack.Push(document);
while (docsStack.Count > 0)
{
var doc = docsStack.Pop();
var doc = docsStack.Peek();

if (doc == TraverseDocOnExitStackMarker)
{
docsStack.Pop();
OnExit(docsStack.Pop());
continue;
}

docsStack.Push(doc);
docsStack.Push(TraverseDocOnExitStackMarker);

if (!OnEnter(doc))
{
OnExit(docsStack.Pop());
continue;
}

docsStack.Push(TraverseDocOnExitStackMarker);

if (doc is Concat concat)
{
// push onto stack in reverse order so they are processed in the original order
Expand Down