perf: use ContainsAnyExceptInRange to calculate width
#1711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 width characters are between 0 and 0x1100, uses
ContainsAnyExceptInRangeto do a vectorised check for characters outside this range. If they are all within the range the width is the exact same as the string length, otherwise we fallback to the old manual loop.I've deliberately outlined
CalculateActualWidthto avoid the cost of jitting and loading the function each time, this does make a small improvement.Benchmarks
This can be tricky, I opted to collect each string that is normally passed to
GetPrintedWidthand use that as the benchmark data. I stored it in a dictionary and then recreate the data and shuffle it to be realistic. Turns out if you don't shuffle the data and just have a series of identical ordered text the branch predictor makes the manual foreach loop the fastest.See #1712 for code
Complex
Tests