Skip to content

Conversation

@JeremyFagis
Copy link

Prepared npm package.

@JeremyFagis JeremyFagis mentioned this pull request Apr 23, 2015
@nervo
Copy link

nervo commented Apr 23, 2015

Wow, need this !
👍

@Tom32i
Copy link

Tom32i commented Apr 23, 2015

👍

1 similar comment
@hyvs
Copy link

hyvs commented Apr 23, 2015

👍

@JeremyJames
Copy link

👍
Absolutely AMAZING ! I want it now !

@woecifaun
Copy link

👍

@kesla
Copy link

kesla commented Apr 23, 2015

@JeremyFagis this isn't enough - is it?

We'd need to do something like

require('sprint.js');
window.$('#beep-boop');

but if we added a commonjs-wrapper (#3) we'd do

var $ = require('sprint.js');

@zc0315
Copy link

zc0315 commented Apr 23, 2015

image

@nervo
Copy link

nervo commented Apr 23, 2015

A better approach would be to use a build system like gulp, who could automize the js minification, and the browser/amd/commonjs module wrapping(via gulp-umd, for instance).

@kitten
Copy link

kitten commented Apr 27, 2015

@kesla Tackled just that problem and #3 in my PR #21. CommonJS, AMD and browser globals support.

@nervo As sprint is not yet modularized and built via gulp this is unnecessary complex

@nervo
Copy link

nervo commented Apr 27, 2015

@philplckthun if you prefer to wrap and minify manually each time you modify a single line of code, why not :)

@kitten
Copy link

kitten commented Apr 27, 2015

@nervo Well, I was not saying that I prefer to minify manually! I said it doesn't make sense to use gulp-umd as long as gulp is not implemented at all. And that should be done with a full modularization of sprint in a seperate branch. 😉

@nervo
Copy link

nervo commented Apr 28, 2015

@philplckthun 'got it :)

@therebelrobot
Copy link

+1

2 similar comments
@jamescostian
Copy link

👍

@rossPatton
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.