fix: release connections to pool after body read #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitc
force-pushed
the
fix/pool-connection-release
branch
2 times, most recently
from
2da0562 to
1e869e6
Compare
Connections are now automatically released to the pool when body reading completes, rather than requiring explicit release calls. This is handled in the connection process itself (hackney_conn) when transitioning from receiving state to connected state. Changes: - hackney_conn: Add auto_release_to_pool in connected(enter, receiving, ...) - hackney_conn: Add should_auto_release/1 and auto_release_to_pool/1 helpers - hackney.erl: Remove safe_release_to_pool (no longer needed) - hackney.erl: For HEAD requests, call body() to trigger auto-release - Test: Add hackney_pool_integration_tests for HTTP/1.1 pool release - Test: Add hackney_pool_h2_tests for HTTP/2 pool behavior HTTP/2 and HTTP/3 connections use multiplexing and are handled differently: - They stay registered in the pool until the connection closes - Pool monitors them and cleans up on DOWN message - Multiple callers share the same connection
benoitc
force-pushed
the
fix/pool-connection-release
branch
from
1e869e6 to
f5211e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
hackney:body/1orstream_body/1body/1,2now releases connection to pool after successful readstream_body/1releases connection when returningdonehackney_pool_integration_testsverifying pool release behaviorPreviously, only requests using the
with_bodyoption would properly release connections. Manual body reading would leave connections in the pool'sin_usecount but not return them for reuse.