-
Notifications
You must be signed in to change notification settings - Fork 6
Features/discovery return counts by ds #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #606 +/- ##
===========================================
- Coverage 93.76% 93.75% -0.01%
===========================================
Files 130 130
Lines 5083 5124 +41
Branches 480 489 +9
===========================================
+ Hits 4766 4804 +38
- Misses 221 222 +1
- Partials 96 98 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
davidlougheed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this code doesn't currently handle the case where users do not have dataset level counts permissions... we need to consider perhaps returning a nested structure with projects and datasets.
Here the discovery endpoint was extended to support per-dataset entity counts, improving granularity for multi-dataset environments. It introduces helpers for fetching and censoring by-dataset counts, and adds them to the response