Skip to content

chore(security): fix blockhash call for a valid previous block hash #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qtipbera wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(security): fix blockhash call for a valid previous block hash #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion contracts/src/Multicall3.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,9 @@ contract Multicall3 {
)
{
blockNumber = block.number;
blockHash = blockhash(block.number);
// blockhash(block.number) always returns 0, so use blockhash(block.number - 1) for a valid previous block hash.
// Note: block.number is always > 0 except for genesis block, so this is safe in normal usage.
blockHash = blockhash(block.number - 1);
returnData = tryAggregate(requireSuccess, calls);
}

Expand Down