This repository was archived by the owner on Apr 19, 2025. It is now read-only.
Open
Conversation
Update package.json peer deps Svelte 4.0.5
Contributor
|
The formatting in this PR is all over the place. Mixes of double quotes and single quotes, unindented code, etc. I think it'd be better to separate the Svelte 4 and Storybook 7 PRs to make them easier to review. This PR is 200 files, which is quite large Also, what's the difference between your Svelte 4 changes and #574? |
# Conflicts: # dist/sveltestrap.es.js # dist/sveltestrap.es.js.map # dist/sveltestrap.js # dist/sveltestrap.js.map # package-lock.json # package.json # src/Accordion.d.ts # src/AccordionHeader.d.ts # src/AccordionItem.d.ts # src/Alert.d.ts # src/Badge.d.ts # src/Breadcrumb.d.ts # src/BreadcrumbItem.d.ts # src/Button.d.ts # src/ButtonDropdown.d.ts # src/ButtonGroup.d.ts # src/ButtonToolbar.d.ts # src/Card.d.ts # src/CardBody.d.ts # src/CardColumns.d.ts # src/CardDeck.d.ts # src/CardFooter.d.ts # src/CardGroup.d.ts # src/CardHeader.d.ts # src/CardImg.d.ts # src/CardImgOverlay.d.ts # src/CardLink.d.ts # src/CardSubtitle.d.ts # src/CardText.d.ts # src/CardTitle.d.ts # src/Carousel.d.ts # src/CarouselCaption.d.ts # src/CarouselControl.d.ts # src/CarouselIndicators.d.ts # src/CarouselItem.d.ts # src/Col.d.ts # src/Colgroup.d.ts # src/Collapse.d.ts # src/Column.d.ts # src/Container.d.ts # src/Dropdown.d.ts # src/DropdownItem.d.ts # src/DropdownMenu.d.ts # src/DropdownToggle.d.ts # src/Fade.d.ts # src/Figure.d.ts # src/Form.d.ts # src/FormCheck.d.ts # src/FormFeedback.d.ts # src/FormGroup.d.ts # src/FormText.d.ts # src/Icon.d.ts # src/Image.d.ts # src/InlineContainer.d.ts # src/Input.d.ts # src/InputGroup.d.ts # src/InputGroupText.d.ts # src/Jumbotron.d.ts # src/Label.d.ts # src/ListGroup.d.ts # src/ListGroupItem.d.ts # src/Modal.d.ts # src/ModalBackdrop.d.ts # src/ModalBody.d.ts # src/ModalFooter.d.ts # src/ModalHeader.d.ts # src/Nav.d.ts # src/NavItem.d.ts # src/NavLink.d.ts # src/Navbar.d.ts # src/NavbarBrand.d.ts # src/NavbarToggler.d.ts # src/Offcanvas.d.ts # src/OffcanvasBackdrop.d.ts # src/OffcanvasBody.d.ts # src/OffcanvasHeader.d.ts # src/Pagination.d.ts # src/PaginationItem.d.ts # src/PaginationLink.d.ts # src/Popover.d.ts # src/Portal.d.ts # src/Progress.d.ts # src/ResponsiveContainer.d.ts # src/Row.d.ts # src/Spinner.d.ts # src/Styles.d.ts # src/TabContent.d.ts # src/TabPane.d.ts # src/Table.d.ts # src/TableFooter.d.ts # src/TableHeader.d.ts # src/Toast.d.ts # src/ToastBody.d.ts # src/ToastHeader.d.ts # src/Tooltip.d.ts # src/index.d.ts # src/shared.d.ts
59 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more of a maintenance PR by which me and my colleague were able to update to Svelte4, Storybook7 and all deprecated packages.
Given that Svelte3 support is not maintained in this PR, and if it is accepted, we may consider making a major release ... e.g. 6.0 rc