feat(Synced): Add DropCurrentUnitAutoTargets for finer control

[Fx-Doo]

Meant to fix #2674

Drop all autoacquired (non user) targets upon receiving a firestate < FIRESTATE_FIREATWILL state command

[Fx-Doo]

Yeah thanks for the correction, this was the wanted behaviour but it must've slipped through when committing, as i had previously tried dropping all.

Btw dropping all doesn't seem to cause any issue either, it's more a matter of staying "clean" i guess.

[sprunk]

returns int

[sprunk]

Looks good, other than the two lines above.

[Fx-Doo]

Fixed the return type // the function definitions in LuaSyncedCtrl.h (wrong name and return type)
Fixed the typo

[badosu]

Where is the part where this function is called? Unless you mean that games should call it manually? What does the "fix" look like?

[Fx-Doo]

Games would be responsible for calling it.
We found some cases where you might want a unit to not drop its current target (mostly the custom guidance fake weapons for retargetting units).
So this seemed a better alternative.
I'll have to make a ready to use simple gadget and test if it works as expected. I havent got the chance to yet.
For BAR we'd need that gadget to exclude some of our units, so i'll add a minimalist exclusion list aswell.

[Fx-Doo]

function gadget:GetInfo()
	return {
		name = "Hold fire means stop firing",
		desc = "",
		author = "DoodVanDaag",
		date = "dec 2025",
		license = "GNU GPL, v2 or later",
		layer = 0,
		enabled = true
	}
end


if gadgetHandler:IsSyncedCode() then

local exclusionList = {}

	function gadget:UnitCommand(unitID, unitDefID, unitTeam, cmdID, cmdParams, cmdOptions)
		if cmdID == CMD.FIRE_STATE and cmdParams[1] <= 1 then
			if not exclusionList[unitDefID] then
				Spring.DropCurrentUnitAutoTargets(unitID)
			-- else
				-- decide what to do (put a timer? remove targets one frame before reload progress is complete ? w/e)
				-- we might actually even want the hold fire command to be applied later on so that it keeps acquiring new targets aswell, in which case the moment it is applied would just drop targets aswell; so maybe the first solution is the one to go and games should delay hold fire instead? Any thoughts on that ?
			end
		end
	end
	
end

Would look like this.

https://www.youtube.com/watch?v=pUTdNWwhJzQ

[Fx-Doo]

I think i overreacted to the "retargetting" projectiles issue.
1st: it's already happenning anyway.
2nd: we can always use the fix just for cloakable units, since others usually drop their targets just fine, for some unknown reason.

[badosu]

I defer to @sprunk, code looks good at a glance