Add status label to application latencies metric #9
Conversation
Previously, the `metricNameAppBlockingLatencies` metric did not include the status label, causing it to be empty in tests and monitoring. This change adds `metricLabelKeyStatus` to the `additionalAttrs` of `metricNameAppBlockingLatencies` in `bigtable/metrics.go`. Also updated `TestApplicationLatencies` in `bigtable/metrics_test.go` to assert the presence and correctness of the status label instead of printing it.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
bhshkh
force-pushed
the
fix/cbt-metric-status
branch
2 times, most recently
from
d4bda73 to
73ba294
Compare
1 participant
Add status label to application latencies metric configuration and update test to verify it.
PR created automatically by Jules for task 2493363852267766948 started by @bhshkh