Fix issue 289 #390
Open
Fix issue 289 #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option for to specify external IP address
Switch from deprecated net-tools (ifconfig, route, ...) to iproute2 package (ip address, ip route, ...), and try to make automatic external IP detection a little bit more reliable.
Member
|
Thanks for this. I'm interested to connect directly. You can reach me at ffdixon .at. bigbluebutton .dot. org. |
Add option for to specify external IP address Merged commit 0165b6d into this branch
Switch from deprecated net-tools (ifconfig, route, ...) to iproute2 package (ip address, ip route, ...), and try to make automatic external IP detection a little bit more reliable. Resolve conflict with master branch.
…to fix-issue-289 Resolving conflict with 90dd654
Contributor
Author
|
The current bigbluebutton:master branch has been merged into michi-80337:fix-issue-289. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch 1/2 adds an option to bbb-install.sh to specify an external IP address on the command line.
Patch 2/2 switches from deprecated net-tools (ifconfig, route, ...) to the iproute2 package (ip address, ip route, ...) and tries to make automatic external IP detection a little bit more reliable.
The patches are independent from each other. Feel free to cherrypick them.