[Feat/#111] 대여 실패시 alert창 #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sinji2102
approved these changes
Mar 9, 2025
Member
sinji2102
left a comment
sinji2102
left a comment
There was a problem hiding this comment.
크게 문제는 없어 보여서 어푸햇습니당~ 고생햇어요
| ); | ||
| const [alertState, setAlertState] = useState<{ | ||
| isOpen: boolean; | ||
| isAlertOpen: boolean; |
Member
There was a problem hiding this comment.
p5) 네이밍 바꾼 거 좋습니당 더 직관적인 것 같아요!
| setErrors({}); | ||
| setAlertState({ isOpen: false }); | ||
| setAlertState({ isAlertOpen: false }); | ||
| setMessageAlertState({ isMessageAlertOpen: false, alertMessage: '' }); |
Member
There was a problem hiding this comment.
p4) 네이밍이 alertState랑 messateAlert가 있어서 뭔가 헷갈리는데... AciontAlert/MessageAlert 나 Comfirm/Alert 등으로 수정하면 좋을 것 같아요!!
Member
Author
There was a problem hiding this comment.
넵 수정해서 올리도록 하겠습니당 감사합니다!
tnals0924
reviewed
Mar 9, 2025
Member
tnals0924
left a comment
tnals0924
left a comment
There was a problem hiding this comment.
대여에 실패했을 때 서버에서 보내주는 에러 메시지를 모달에 띄워주시면 좋을 것 같습니다!
Member
Author
넵 감사합니다!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
Check List
✅ Key Changes
📢 To Reviewers
📸 스크린샷
현재 멘트는 대여 -> 대여 신청 으로 변경하였습니다.
대여 실패시
대여 성공시
🔗 참고 자료