Support adding attributes to each test and async tests#10
Merged
JonathanBrouwer merged 4 commits intobinary-banter:mainfrom May 16, 2025
robgjansen:attr
Merged
Support adding attributes to each test and async tests#10JonathanBrouwer merged 4 commits intobinary-banter:mainfrom robgjansen:attr
JonathanBrouwer merged 4 commits intobinary-banter:mainfrom
robgjansen:attr
Conversation
Contributor
|
Looks good to me, I'll do a more in depth review tomorrow to check out the code but this can probably be merged (close to?) as is. I'm also open to the async tests feature, can be a separate PR or in this one as a separate commit, whatever you prefer |
robgjansen
changed the title
Contributor
Author
|
I think it is easier to just push both commits here. Thanks for your quick feedback on these in the issue tracker! |
Contributor
|
I've made some minor improvements and added tests. Other than that the work is great, thank you so much! |
Contributor
|
I've released this as test-each-file 0.3.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses similar code to that which parses extensions.
closes #9
My use case also requires async tests,
but that should probably be a separate PR.closes #11