rpcconsole: display signet challenge by RandyMcMillan · Pull Request #896 · bitcoin-core/gui

RandyMcMillan · 2025-09-24T00:13:09Z

Motivation:

This pull request aims to enhance the RPC console by displaying the signet challenge, providing users with crucial network configuration information directly within the console. This improves usability and clarity, especially for users interacting with custom signet networks.

Use Cases:

Verifying Signet Configuration: Users can quickly verify the active signet challenge when connecting to a custom signet, ensuring they are on the intended network.
Improved User Experience: For developers and advanced users working with multiple signet environments, having the challenge readily visible in the RPC console reduces the need to look up configuration details elsewhere.

DrahtBot · 2025-09-24T00:13:16Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

No conflicts as of last run.

RandyMcMillan · 2025-09-24T00:15:00Z

display an elided signet challenge

hebasto · 2025-09-25T10:27:49Z

cc @Sjors

luke-jr · 2025-09-25T10:42:57Z

src/qt/rpcconsole.cpp

+            std::string challenge_end = challengeString.substr(challengeString.length() - 8);
+
+            ui->networkName->setText(
+                tr("Signet: (%1...%2)").arg(


Might be a better way to elide the middle so that a copy/paste gets the full string?

Testing a proper Qt interface for better formatting now.

RandyMcMillan · 2025-09-25T20:49:37Z

src/util/strencodings.cpp

    return str;
 }

+std::string ChallengeToStdString(const std::vector<uint8_t>& v)


move ChallengeToStdString to src/util/strencodings.cpp for later availability in main window.

RandyMcMillan · 2025-09-25T20:50:11Z

src/qt/rpcconsole.cpp

    return QWidget::eventFilter(obj, event);
 }

-std::string RPCConsole::challengeToString(const std::vector<uint8_t>& v)


removed std::string RPCConsole::challengeToString(const std::vector<uint8_t>& v)

RandyMcMillan · 2025-09-25T20:51:53Z

added "trivial challenge" support per signet implementation.

RandyMcMillan · 2025-09-25T20:54:23Z

handle long challenges with proper elision and text flow.

RandyMcMillan · 2025-09-25T20:55:47Z

common length challenges elide and flow correctly.

pablomartin4btc

It would be good to put the label "challenge:" in both the info tab and the title, and also differentiate between the default challenge and the custom one (specified by -signetchallenge=). With this in mind perhaps when there's no custom challenge specified we don't update the window title but only the info tab ("Name: Signet (challenge: 512103ad...e6c452ae, default)" or something like that).

For the conversion you can use HexStr() instead of ChallengeToStdString().

RandyMcMillan · 2025-09-25T21:17:12Z

It would be good to put the label "challenge:" in both the info tab and the title, and also differentiate between the default challenge and the custom one (specified by -signet_challenge). With this in mind perhaps when there's no custom challenge specified we don't update the window title but only the info tab ("Name: Signet (challenge: 512103ad...e6c452ae, default)" or something like that).

For the conversion you can use HexStr() instead of ChallengeToStdString().

i was thinking a long the same lines.

I will test against bitcoin/bitcoin#29838

and make a decision - trying to avoid a conflict. :)

RandyMcMillan · 2025-09-25T21:21:08Z

also trying to treat the challenge as a fingerprint - avoiding clutter in the title but the rcpconsole formatting ought to look ok.

RandyMcMillan · 2025-09-25T23:36:00Z

fixed typo and commit scope
add Network Name with Challenge on new line per @pablomartin4btc feed back
Challenge Copy&Paste-able from gui per @luke-jr feed back
Detect Default signet_challenge and display "Default"
Removed parenthesis in rpcconsole panel, keep in title

RandyMcMillan · 2025-09-25T23:37:33Z

tooltip displays challenge (even if obfuscated in rpcconsole)

RandyMcMillan · 2025-09-25T23:38:19Z

when default signet_challenge detected:

RandyMcMillan · 2025-09-25T23:39:08Z

when common length signet_challenge:

RandyMcMillan · 2025-09-25T23:46:12Z

src/qt/rpcconsole.cpp

    return QWidget::eventFilter(obj, event);
 }

-std::string RPCConsole::challengeToString(const std::vector<uint8_t>& v)


squash later

RandyMcMillan · 2025-09-25T23:46:22Z

src/qt/rpcconsole.h

    virtual bool eventFilter(QObject* obj, QEvent *event) override;
    void keyPressEvent(QKeyEvent *) override;
    void changeEvent(QEvent* e) override;
-    std::string challengeToString(const std::vector<uint8_t>& v);


squash later

RandyMcMillan · 2025-09-25T23:48:20Z

src/qt/rpcconsole.cpp

 const char fontSizeSettingsKey[] = "consoleFontSize";

+const std::string DEFAULT_CHALLENGE_STRING =
+    "512103AD5E0EDAD18CB1F0FC0D28A3D4F1F3E445640337489ABB10404F2D1E086BE430210359EF5021964FE22D6F8E05B2463C9540CE96883FE3B278760F048F5189F2E6C452AE";


maybe a global constant?

RandyMcMillan · 2025-09-25T23:56:41Z

src/qt/rpcconsole.h

+    }
+
+    // Provide the full challenge when Copy&Paste
+    QMimeData* createMimeDataFromSelection() const {


the full challenge should be copy and pasted - please test
cc: @luke-jr @pablomartin4btc

RandyMcMillan · 2025-09-26T16:13:13Z

use HexStr() per pablomartin4btc suggestion
use lower case DEFAULT_CHALLENGE_STRING for comparison

RandyMcMillan · 2025-09-28T16:09:37Z

rebase on top of gui/master

temporarily cherry-pick PR bitcoin/bitcoin#33480 to fix an issue.

hebasto · 2025-11-18T23:30:39Z

@RandyMcMillan

The PR description is currently empty. Could you please add the motivation for this change, along with a few example use cases?

RandyMcMillan mentioned this pull request Sep 24, 2025

Feature: Use different datadirs for different signets bitcoin/bitcoin#29838

Closed

luke-jr reviewed Sep 25, 2025

View reviewed changes

RandyMcMillan commented Sep 25, 2025

View reviewed changes

pablomartin4btc reviewed Sep 25, 2025

View reviewed changes

RandyMcMillan force-pushed the pr/1919/916101/674094/b4aa9f5f7b1/eb918d0c31d-rpcconsole-signet-challenge branch from d166b3b to 5f06fbb Compare September 25, 2025 23:32

RandyMcMillan commented Sep 25, 2025

View reviewed changes

RandyMcMillan force-pushed the pr/1919/916101/674094/b4aa9f5f7b1/eb918d0c31d-rpcconsole-signet-challenge branch 2 times, most recently from f358239 to f4bc05a Compare September 26, 2025 16:11

RandyMcMillan force-pushed the pr/1919/916101/674094/b4aa9f5f7b1/eb918d0c31d-rpcconsole-signet-challenge branch 3 times, most recently from c5b9f67 to 0496ce5 Compare September 28, 2025 16:06

DrahtBot mentioned this pull request Sep 29, 2025

ci: detect outbound internet traffic generated while running tests bitcoin/bitcoin#31349

Open

This was referenced Sep 29, 2025

ci: Turn CentOS config into Alpine musl config bitcoin/bitcoin#33480

Merged

ci: clear out space on CentOS, depends, gui GHA job bitcoin/bitcoin#33514

Merged

DrahtBot mentioned this pull request Oct 7, 2025

DRAFT: add a freebsd job using systemlibs bitcoin/bitcoin#33562

Closed

DrahtBot added the Needs rebase label Oct 15, 2025

rpcconsole:display signet_challenge

db1c408

RandyMcMillan force-pushed the pr/1919/916101/674094/b4aa9f5f7b1/eb918d0c31d-rpcconsole-signet-challenge branch from 0496ce5 to db1c408 Compare November 11, 2025 02:40

RandyMcMillan requested review from luke-jr and pablomartin4btc November 11, 2025 06:52

DrahtBot removed the Needs rebase label Nov 11, 2025

Conversation

RandyMcMillan commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation:

Uh oh!

DrahtBot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews

Conflicts

Uh oh!

RandyMcMillan commented Sep 24, 2025

Uh oh!

hebasto commented Sep 25, 2025

Uh oh!

luke-jr Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan commented Sep 25, 2025

Uh oh!

RandyMcMillan commented Sep 25, 2025

Uh oh!

RandyMcMillan commented Sep 25, 2025

Uh oh!

pablomartin4btc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan commented Sep 25, 2025

Uh oh!

RandyMcMillan commented Sep 25, 2025

Uh oh!

RandyMcMillan commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RandyMcMillan commented Sep 25, 2025

Uh oh!

RandyMcMillan commented Sep 25, 2025

Uh oh!

RandyMcMillan commented Sep 25, 2025

Uh oh!

RandyMcMillan Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RandyMcMillan commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented Nov 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

RandyMcMillan commented Sep 24, 2025 •

edited

Loading

DrahtBot commented Sep 24, 2025 •

edited

Loading

pablomartin4btc left a comment •

edited

Loading

RandyMcMillan commented Sep 25, 2025 •

edited

Loading

RandyMcMillan Sep 25, 2025 •

edited

Loading

RandyMcMillan commented Sep 26, 2025 •

edited

Loading

RandyMcMillan commented Sep 28, 2025 •

edited

Loading