Fix various CI nits before backporting 29.x commits.#105
Merged
ajtowns merged 3 commits intobitcoin-inquisition:29.xfrom Feb 6, 2026
Merged
Fix various CI nits before backporting 29.x commits.#105ajtowns merged 3 commits intobitcoin-inquisition:29.xfrom
ajtowns merged 3 commits intobitcoin-inquisition:29.xfrom
Conversation
Clear out space on the centos job be deleteing unnecessary files. Raised by bitcoin#33293 which pointed to a solution like google/oss-fuzz@b7f04d7 Only runs when cache provider (runner) is `gha`, and on the CentOS job. Github-Pull: bitcoin#33514 Rebased-From: e07e573
Presumably `do{...}while(0)` in macros makes tidy think that a
`std::move()` with the macro arguments can be invoked twice. Fix this
by just not using std::move() within the boost macros. Also add
a recursion annotation.
Also just use std::move rather than std::forward when we know the
variable's exact type.
Author
|
Needed some additional changes so that bip54 tests don't trigger complaints. |
Author
|
ASAN CI failure seems to be github confusing itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #101 for background.