Closed
Conversation
|
Concept ACK, matches BIP 349 |
stevenroose
approved these changes
Jun 23, 2025
Collaborator
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
instagibbs
force-pushed
the
2025-03-ikey-inq-28
branch
from
0411d23 to
5310f1c
Compare
Author
|
pushed update with some tests |
instagibbs
force-pushed
the
2025-03-ikey-inq-28
branch
from
5310f1c to
76ecc73
Compare
|
Rebase for CI rerun? |
instagibbs
force-pushed
the
2025-03-ikey-inq-28
branch
from
76ecc73 to
5a7df97
Compare
Author
|
BIN-2024-0003 already has a BINANA number, which should simplify things. |
Author
|
closing for now since 29.x is active |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same deal as #72, split out from #45