wallet: derivehdkey RPC to get xpub at arbitrary path by Sjors · Pull Request #32784 · bitcoin/bitcoin

Sjors · 2025-06-20T11:04:39Z

Given a (blank) wallet with an unused(KEY) descriptor, derivehdkey "m/87h/0h/0h" gets the xpub or xpriv at any given path.

This is particularly useful for multisig setup where it's not desirable to use our default derivations (e.g. 44h).

I updated the multisig tutorial and the functional test.

Based on:

wallet: addhdkey RPC to add just keys to wallets via new unused(KEY) descriptor #29136

DrahtBot · 2025-06-20T11:04:44Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32784.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	rkrux

If your review is incorrectly listed, please copy-paste  into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#33874 (wallet: refactor ProcessDescriptorImport by naiyoma)
#33392 (wallet, rpc: add UTXO set check and incremental rescan to importdescriptors by musaHaruna)
#33008 (wallet: support bip388 policy with external signer by Sjors)
#31668 (Added rescan option for import descriptors by saikiran57)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

LLM Linter (✨ experimental)

Possible places where named args for integral literals may be used (e.g. func(x, /*named_arg=*/0) in C++, and func(x, named_arg=0) in Python):

Parse(desc_str, keys, error, false) in src/wallet/rpc/wallet.cpp
WalletDescriptor(std::move(descs.at(0)), GetTime(), 0, 0, 0) in src/wallet/rpc/wallet.cpp

^{2026-02-02 15:38:12}

DrahtBot · 2025-06-20T11:47:19Z

🚧 At least one of the CI tasks failed.
_{Task lint: https://github.com/bitcoin/bitcoin/runs/44475268764}
_{LLM reason (✨ experimental): The CI failure is caused by errors from the lint check 'py_lint', specifically due to unused imports flagged by ruff.}

Hints

Try to run the tests locally, according to the documentation. However, a CI failure may still
happen due to a number of reasons, for example:

Possibly due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the
affected test.
An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

DrahtBot · 2025-06-25T09:41:34Z

src/rpc/util.h

In util.h: “@params[in] path” → “@param[in] path” [Doxygen tag typo]

DrahtBot · 2025-07-02T04:37:05Z

doc/multisig-tutorial.md

addressesd -> addresses [extra “d” makes “addresses” misspelled]

rkrux · 2025-07-18T11:11:25Z

Very nice, Concept ACK.
I will review this PR.

Sjors · 2025-09-26T10:15:56Z

(will rebase this later)

Sjors · 2026-01-05T04:05:29Z

Rebased after #32821 landed and #29136 was rebased. Re-tested by having an LLM follow the tutorial.

unused() descriptors do not have scriptPubKeys. Instead, the wallet uses them to store keys without having any scripts to watch for.

Use derivehdkey instead of extracting each participant xpub (and derivation info) from the listdescriptors output. Additionally use the new <0;1> descriptor syntax. Finally this commits adds a few debug log lines, and expand the explanation for why we use m/44h/1h/0h.

Use derivehdkey instead of extracting each participant xpub from the listdescriptors output. Additionally use the new <0;1> descriptor syntax. Also use bitcoin rpc instead of bitcoin-cli.

DrahtBot changed the title ~~wallet: derivehdkey RPC to get xpub at arbitrary path~~ wallet: derivehdkey RPC to get xpub at arbitrary path Jun 20, 2025

DrahtBot added the Wallet label Jun 20, 2025

Sjors mentioned this pull request Jun 20, 2025

wallet: addhdkey RPC to add just keys to wallets via new unused(KEY) descriptor #29136

Open

DrahtBot added the CI failed label Jun 20, 2025

DrahtBot mentioned this pull request Jun 20, 2025

Menu action to export a watchonly wallet bitcoin-core/gui#872

Draft

Sjors force-pushed the 2025/06/gethdkey branch 2 times, most recently from de7f5c6 to 3f35b02 Compare June 20, 2025 14:58

Sjors mentioned this pull request Jun 20, 2025

Awesome multisig PR labyrinth guide #24861

Open

16 tasks

This was referenced Jun 20, 2025

wallet: add codex32 argument to addhdkey #32652

Closed

wallet: Add exportwatchonlywallet RPC to export a watchonly version of a wallet #32489

Open

Sjors force-pushed the 2025/06/gethdkey branch from 3f35b02 to 30d5e5c Compare June 20, 2025 17:25

DrahtBot removed the CI failed label Jun 20, 2025

This was referenced Jun 20, 2025

descriptors: taproot partial descriptors #30243

Closed

wallet: Construct ScriptPubKeyMans with all data rather than loaded progressively #28333

Open

DrahtBot reviewed Jun 25, 2025

View reviewed changes

src/rpc/util.h Outdated

Copy link

Contributor

DrahtBot Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In util.h: “@params[in] path” → “@param[in] path” [Doxygen tag typo]

This was referenced Jun 25, 2025

MuSig2 with script path fallback pubnonce failure LedgerHQ/app-bitcoin-new#329

Closed

MuSig2 power Sjors/bitcoin#91

Open

Sjors force-pushed the 2025/06/gethdkey branch from 30d5e5c to 199c513 Compare June 26, 2025 13:26

DrahtBot mentioned this pull request Jun 26, 2025

Permit Combiner to strip bip32_deriv information #30341

Closed

Sjors force-pushed the 2025/06/gethdkey branch from 199c513 to 35eec44 Compare June 27, 2025 12:01

Sjors mentioned this pull request Jun 27, 2025

rpc: Handle -named argument parsing where '=' character is used #32821

Merged

DrahtBot reviewed Jul 2, 2025

View reviewed changes

doc/multisig-tutorial.md Outdated

Copy link

Contributor

DrahtBot Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressesd -> addresses [extra “d” makes “addresses” misspelled]

Sjors mentioned this pull request Jul 3, 2025

Have createwalletdescriptor auto-detect an unused(KEY) #32861

Draft

DrahtBot mentioned this pull request Jul 14, 2025

Silent Payments: Receiving #32966

Draft

DrahtBot mentioned this pull request Jul 18, 2025

wallet: support bip388 policy with external signer #33008

Draft

4 tasks

Sjors force-pushed the 2025/06/gethdkey branch 2 times, most recently from 380a57f to 017fb68 Compare August 1, 2025 10:52

This was referenced Aug 5, 2025

wallet: warn against accidental unsafe older() import #33135

Merged

BIP360: Includes the following: #33163

Closed

DrahtBot mentioned this pull request Aug 21, 2025

cli: Handle arguments that can be either JSON or string #33230

Merged

DrahtBot mentioned this pull request Sep 2, 2025

doc: update multisig tutorial to use multipath descriptors #33286

Merged

DrahtBot mentioned this pull request Sep 20, 2025

wallet, rpc: add UTXO set check and incremental rescan to importdescriptors #33392

Open

DrahtBot added the Needs rebase label Sep 25, 2025

Sjors force-pushed the 2025/06/gethdkey branch from 017fb68 to 2d40e1e Compare January 5, 2026 04:05

DrahtBot removed the Needs rebase label Jan 5, 2026

DrahtBot mentioned this pull request Jan 5, 2026

wallet: refactor ProcessDescriptorImport #33874

Closed

achow101 added 6 commits January 5, 2026 14:23

descriptor: Add unused(KEY) descriptor

9ea534f

unused() descriptors do not have scriptPubKeys. Instead, the wallet uses them to store keys without having any scripts to watch for.

test: Simple test for importing unused(KEY)

05fb11d

wallet: Add addhdkey RPC

7109d3a

wallet, rpc: Disallow import of unused() if key already exists

8a73206

wallet, rpc: Disallow importing unused() to wallets without privkeys

1e62c53

doc: Release note for addhdkey

23f5529

DrahtBot mentioned this pull request Jan 5, 2026

Added rescan option for import descriptors #31668

Open

This was referenced Jan 17, 2026

wallet: Fix MaxSatisfactionWeight calculation for Taproot descriptors #34314

Closed

scripted-diff: Type-safe settings retrieval #31260

Open

DrahtBot mentioned this pull request Jan 29, 2026

wallet: add gethdkey RPC for BIP 32 key derivation #34438

Closed

Sjors added 6 commits February 2, 2026 16:32

rpc: add DeriveExtKey() helper

20020bf

Have ParseHDKeypath handle h derivation marker

9b70b7d

rpc: ParsePathBIP32 helper

48e20cf

rpc: add derivehdkey

6dafa51

doc: use derivehdkey in multisig tutorial

18cbcb1

Use derivehdkey instead of extracting each participant xpub from the listdescriptors output. Additionally use the new <0;1> descriptor syntax. Also use bitcoin rpc instead of bitcoin-cli.

Sjors force-pushed the 2025/06/gethdkey branch from 2d40e1e to 18cbcb1 Compare February 2, 2026 15:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wallet: derivehdkey RPC to get xpub at arbitrary path#32784

wallet: derivehdkey RPC to get xpub at arbitrary path#32784
Sjors wants to merge 12 commits intobitcoin:masterfrom
Sjors:2025/06/gethdkey

Sjors commented Jun 20, 2025 •

edited

Loading

Uh oh!

DrahtBot commented Jun 20, 2025 •

edited

Loading

Uh oh!

DrahtBot commented Jun 20, 2025

Uh oh!

DrahtBot Jun 25, 2025

Uh oh!

DrahtBot Jul 2, 2025

Uh oh!

rkrux commented Jul 18, 2025

Uh oh!

Sjors commented Sep 26, 2025

Uh oh!

Sjors commented Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Sjors commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage & Benchmarks

Reviews

Conflicts

LLM Linter (✨ experimental)

Uh oh!

DrahtBot commented Jun 20, 2025

Uh oh!

DrahtBot Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

DrahtBot Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

rkrux commented Jul 18, 2025

Uh oh!

Sjors commented Sep 26, 2025

Uh oh!

Sjors commented Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sjors commented Jun 20, 2025 •

edited

Loading

DrahtBot commented Jun 20, 2025 •

edited

Loading