Refactor most interfaces to use SP prefix #246
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigraw
approved these changes
Oct 14, 2025
Collaborator
craigraw
left a comment
craigraw
left a comment
There was a problem hiding this comment.
As promised I've only done a light review of this. @msgilligan and I discussed camelcase (eg SpPrivateKey) instead, happy to go with whatever the maintainers decide is best though.
Refactor most interfaces in the pubic API to use the `SP` prefix. (All but `Secp256k1` and `Secp256k1Provider`)
msgilligan
force-pushed
the
msgilligan/SP-prefix
branch
from
c11e7cc to
037d04d
Compare
Member
Author
|
This should be rebased (or recreated) after PR #259 is merged. |
Member
Author
|
Closing in favor of PR #274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor most interfaces in the pubic API to use the
SPprefix. (All butSecp256k1andSecp256k1Provider)This is a child of PR #244 and should be rebased once that is merged.