Update consensus branch ID for Canopy activation#12
Open
simbav911 wants to merge 1 commit intobitcoinz-dev-tools:masterfrom
Open
Update consensus branch ID for Canopy activation#12simbav911 wants to merge 1 commit intobitcoinz-dev-tools:masterfrom
simbav911 wants to merge 1 commit intobitcoinz-dev-tools:masterfrom
Conversation
Canopy activated at block 1,735,000 on BitcoinZ mainnet. Transactions must be signed with the Canopy branch ID or nodes will reject them. This fixes wallet breakage for any wallet using bitcore-lib-btcz (VDL, Coinomi, etc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x76b809bb) to Canopy (0xe9ff75a6)Why this is needed
After Canopy activation, any wallet using this library (VDL, Coinomi, etc.) creates transactions signed with the old Sapling branch ID. Nodes reject these transactions because Canopy requires the new branch ID in the sighash personalization.
This one-line fix restores wallet functionality for all downstream consumers of bitcore-lib-btcz.
Temporary fix
Until this PR is merged, wallets can point to the fork at
z-bitcoinz/bitcore-lib-btczwhich already includes this fix.