fix: Delete confusing assertion in test #307
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackheaven
reviewed
Nov 5, 2024
| insertedConflict <- tryEsError $ insertData' cfg | ||
| case insertedConflict of | ||
| Right (res', _) -> liftIO $ isVersionConflict res' `shouldBe` True | ||
| Right _ -> liftIO $ expectationFailure "This should never not happen." |
Contributor
Author
There was a problem hiding this comment.
That's a too much Git magic to create small PRs-mistake. Sorry for the noise - I'm fixing it.
The assertion implied that a version conflict can lead to a Right value (maybe for either ElasticSearch or OpenSearch.) However, the parsing logic would force this to be a Left value.
supersven
force-pushed
the
improve-version-conflict-test
branch
from
05ba926 to
72b2168
Compare
blackheaven
force-pushed
the
master
branch
4 times, most recently
from
19e7d73 to
3789abe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assertion implied that a version conflict can lead to a Right value (maybe for either ElasticSearch or OpenSearch.) However, the parsing logic would force this to be a Left value.