Replace ecdsa with cryptography for key generation and signing #221#222
Open
swlodarski-sumoheavy wants to merge 1 commit intobitpay:8.0.xfrom
Open
Replace ecdsa with cryptography for key generation and signing #221#222swlodarski-sumoheavy wants to merge 1 commit intobitpay:8.0.xfrom
swlodarski-sumoheavy wants to merge 1 commit intobitpay:8.0.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #221
Summary
This PR migrates the cryptographic operations from the
ecdsalibrary topyca/cryptography, providing a more secure, actively maintained, and industry-standard cryptographic library for SECP256K1 key generation and ECDSA signing.Changes
Dependencies
pyproject.toml: Replacedecdsa >= 0.19.1withcryptography >= 44.0.0Pipfile: Updated package dependency to usecryptography >= 44.0.0Code Changes
ecdsaimports withcryptography.hazmat.primitivesmodulestyping.castfor type safety with mypygenerate_pem(): Migrated fromSigningKey.generate(curve=SECP256k1)toec.generate_private_key(ec.SECP256K1())get_compressed_public_key_from_pem(): Updated to useserialization.load_pem_private_key()and extract public key coordinates viapublic_numbers()with explicit type castingsign(): Replaced ecdsa's DER-encoded signing with cryptography'sEllipticCurvePrivateKey.sign()using ECDSA with SHA256Why This Change?
pyca/cryptographyis the industry-standard cryptographic library with regular security audits and FIPS-compliant implementationsTechnical Details
All cryptographic operations remain functionally equivalent:
Breaking Changes
None. The public API remains unchanged; only the underlying cryptographic implementation has been updated.
Testing