fix orchestrator startup crash in DualStack cluster #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a cluster where `.Env.HOSTNAME` resolves to an IPv6 address, the orchestrator fails to start due to a syntax error in the raft bind address. This was reported here: bitpoke#929 This commit fixes this, at least for DualStack clusters, by using `.Env.POD_IP` instead, which is defined as ```yaml - name: POD_IP valueFrom: fieldRef: apiVersion: v1 fieldPath: status.podIP ``` and thus typically points to an IPv4 address in DualStack clusters. For a general fix, the orchestrator code itself probably needs to be modified to correctly handle the bind hostname.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a cluster where
.Env.HOSTNAMEresolves to an IPv6 address, the orchestrator fails to start due to a syntax error in the raft bind address. This was reported here: #929This commit fixes this, at least for DualStack clusters, by using
.Env.POD_IPinstead, which is defined asand thus typically points to an IPv4 address in DualStack clusters. For a general fix, the orchestrator code itself probably needs to be modified to correctly handle the bind hostname.