Skip to content

Conversation

@godrei
Copy link
Contributor

@godrei godrei commented Oct 29, 2025

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a PATCH version update

Context

iOS test result deployment can fail without a clear error messages about the problem, like:

Collecting test results...
Using new extraction method
Failed to parse extraction method: invalid character '+' looking for beginning of value
Falling back to legacy extraction method
Using legacy extraction method
Failed to parse test results: invalid character '+' looking for beginning of value

This PR improves on this issue, by handling xcresulttool stdout and stderr separately.

@godrei godrei changed the title Treat xcresulttool stdout and stderr separatly Treat xcresulttool stdout and stderr separately Oct 29, 2025
scanner := bufio.NewScanner(strings.NewReader(out))
for scanner.Scan() {
lines = append(lines, scanner.Text())
if len(lines) == 3 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be more like 10?

In the past we had such a thing where Xcode could not load some library because it was already loaded and the first two lines of the garbage output was the same thing. We might lose some interesting bit of info with only logging the first three lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in: a3f3ecd

@godrei godrei marked this pull request as ready for review October 30, 2025 08:47
@godrei godrei merged commit cb239c9 into master Oct 30, 2025
1 check passed
@godrei godrei deleted the fix-xcresult-parsing branch October 30, 2025 09:04
@godrei godrei changed the title Treat xcresulttool stdout and stderr separately Handle xcresulttool stdout and stderr separately Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants