Skip to content

Conversation

@addisonbeck
Copy link
Contributor

  • Extend build-wasm-internal.yml with trigger-breaking-change-check job
  • Add consolidated comment strategy for real-time status updates
  • Implement synchronous workflow coordination with 10min timeout
  • Add comprehensive error handling and retry mechanisms
  • Include Azure Key Vault PAT token integration
  • Add Breaking Changes section to PR template
  • Support for matrix strategy (ready for mobile expansion)

Implements comprehensive SDK CI breaking change detection per PM-22218

🎟️ Tracking

📔 Objective

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@addisonbeck addisonbeck force-pushed the ci-warn-on-breaking-changes branch from 204dc59 to 011bf58 Compare October 28, 2025 15:56
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

Logo
Checkmarx One – Scan Summary & Details6a3f8e32-445e-4f0c-856f-316c68cc870f

Great job! No new security vulnerabilities introduced in this pull request

@addisonbeck addisonbeck force-pushed the ci-warn-on-breaking-changes branch 9 times, most recently from 6a089bd to 307ed34 Compare October 28, 2025 19:16
- Extend build-wasm-internal.yml with trigger-breaking-change-check job
- Add consolidated comment strategy for real-time status updates
- Implement synchronous workflow coordination with 10min timeout
- Add comprehensive error handling and retry mechanisms
- Include Azure Key Vault PAT token integration
- Add Breaking Changes section to PR template
- Support for matrix strategy (ready for mobile expansion)

Implements comprehensive SDK CI breaking change detection per PM-22218
@addisonbeck addisonbeck force-pushed the ci-warn-on-breaking-changes branch from 307ed34 to 235c6d1 Compare October 28, 2025 19:42
@bitwarden bitwarden deleted a comment from bw-ghapp bot Oct 29, 2025
@bitwarden bitwarden deleted a comment from bw-ghapp bot Oct 29, 2025
@bw-ghapp
Copy link
Contributor

bw-ghapp bot commented Oct 29, 2025

🔍 SDK Breaking Change Detection Results

SDK Version: ci-warn-on-breaking-changes (dd85de4)
Completed: 2025-10-29 20:18:32 UTC
Total Time: Unknowns

Client Status Details
typescript ⚠️ Unknown status Workflow completed with unclear results

Breaking change detection completed. View SDK workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants