Prevent throwing KeyError when loading save options for deleted mod.#73
Open
Justin99x wants to merge 1 commit intobl-sdk:masterfrom
Open
Prevent throwing KeyError when loading save options for deleted mod.#73Justin99x wants to merge 1 commit intobl-sdk:masterfrom
Justin99x wants to merge 1 commit intobl-sdk:masterfrom
Conversation
Collaborator
|
Fwiw I'm not going to merge this while there are still CI errors, and I get if you don't want to bother with it since none of them are your fault. I'm content to just leave this open until we next update this repo, given it took 7mo for anyone to run into the bug it doesn't seem particularly urgent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just need to continue to load other mods' data and log a warning when a mod we're loading data for doesn't exist anymore (user deleted).