Add unset_color to Node (and start for Edge)#300
Open
oscargus wants to merge 2 commits intoblitzarx1:mainfrom
Open
Add unset_color to Node (and start for Edge)#300oscargus wants to merge 2 commits intoblitzarx1:mainfrom
oscargus wants to merge 2 commits intoblitzarx1:mainfrom
Conversation
oscargus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The (very) easy part of #287. I have tried to do something similar to edges, but to no avail so I just add this method.
The reason is that one can then color a node programmatically and then restore it without knowing the default color.
The naming can be discussed, but I thought
unsetwas at least better thanreset.Edit: the second commit adds a color member to
EdgePropsand the corresponding methods toEdge. However, I have not been able to figure out how to fetch this information in the correct location. But FWIW.