run tests in github actions#10
Closed
oliver-block wants to merge 1 commit intoblock:mainfrom
oliver-block:github_actions
Closed
run tests in github actions#10oliver-block wants to merge 1 commit intoblock:mainfrom oliver-block:github_actions
oliver-block wants to merge 1 commit intoblock:mainfrom
oliver-block:github_actions
Conversation
sanket1729
reviewed
Aug 16, 2025
| uses: cashapp/activate-hermit@v1 | ||
|
|
||
| - name: Run tests | ||
| run: gradle build |
There was a problem hiding this comment.
Can we add linting checks here too?
Collaborator
Author
There was a problem hiding this comment.
gradle build runs the linter as well
kevkevinpal
reviewed
Aug 16, 2025
| uses: cashapp/activate-hermit@v1 | ||
|
|
||
| - name: Run tests | ||
| run: gradle build |
Contributor
There was a problem hiding this comment.
Any reason to use gradle build over gradle test for this action?
Collaborator
Author
There was a problem hiding this comment.
README says to run "gradle build" for the tests. plus it runs the linter - see question above.
Collaborator
Author
|
Closing this in favor of #13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9