Skip to content

fix: We should check if the mempool is loaded instead of taking an empty array #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevkevinpal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: We should check if the mempool is loaded instead of taking an empty array #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions app/src/main/kotlin/xyz/block/augurref/bitcoin/BitcoinRpcClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ class BitcoinRpcClient(private val config: BitcoinRpcConfig) {
"method" to "getrawmempool",
"params" to listOf(true),
),
mapOf(
"jsonrpc" to "1.0",
"id" to "mempool-info",
"method" to "getmempoolinfo",
"params" to emptyList<String>(),
),
),
)

Expand Down Expand Up @@ -92,6 +98,13 @@ class BitcoinRpcClient(private val config: BitcoinRpcConfig) {
if (mempoolResponse.error != null) {
throw Exception("RPC error (mempool): ${mempoolResponse.error}")
}
val mempoolInfoResponse: MempoolInfoResponse = mapper.convertValue(results[2], MempoolInfoResponse::class.java)
if (mempoolInfoResponse.error != null) {
throw Exception("RPC error (mempool-info): ${mempoolInfoResponse.error}")
}
if (mempoolInfoResponse.result?.loaded == false) {
throw Exception("RPC error (mempool-info): mempool is not loaded")
}

// Convert directly from Bitcoin Core MempoolEntry to Augur MempoolTransaction
val transactions = mempoolResponse.result?.map { (_, entry) ->
Expand Down Expand Up @@ -138,3 +151,22 @@ data class BlockchainInfoResponse(
val result: BlockchainInfo?,
val error: Any?,
)

data class MempoolInfo(
val loaded: Boolean,
val size: Int,
val bytes: Int,
val usage: Int,
val totalFee: Double,
val maxmempool: Int,
val mempoolminfee: Double,
val minrelaytxfee: Double,
val incrementalrelayfee: Double,
val unbroadcastcount: Int,
val fullrbf: Boolean,
)

data class MempoolInfoResponse(
val result: MempoolInfo?,
val error: Any?,
)