Skip to content

fix(ui): make PR/push backend calls non-blocking for immediate UI feedback #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt2e merged 1 commit into from
Mar 19, 2026
Merged

fix(ui): make PR/push backend calls non-blocking for immediate UI feedback #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 29 additions & 23 deletions apps/staged/src/lib/features/branches/BranchCardPrButton.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,21 +357,24 @@
// PR creation
// =========================================================================

async function handleCreatePr(draft = false) {
function handleCreatePr(draft = false) {
if (prState === 'creating') return;

prStateStore.setPrCreating(branch.id, '__pending__');

try {
const agents = isRemote ? REMOTE_AGENTS : agentState.providers;
const provider = getPreferredAgent(agents) ?? undefined;
const sessionId = await commands.createPr(branch.id, provider, draft);
sessionRegistry.register(sessionId, branch.projectId, 'pr', branch.id);
prStateStore.setPrCreating(branch.id, sessionId);
projectStateStore.addRunningSession(branch.projectId, sessionId);
} catch (e) {
prStateStore.setPrError(branch.id, e instanceof Error ? e.message : String(e));
}
const agents = isRemote ? REMOTE_AGENTS : agentState.providers;
const provider = getPreferredAgent(agents) ?? undefined;

commands
.createPr(branch.id, provider, draft)
.then((sessionId) => {
sessionRegistry.register(sessionId, branch.projectId, 'pr', branch.id);
prStateStore.setPrCreating(branch.id, sessionId);
projectStateStore.addRunningSession(branch.projectId, sessionId);
})
.catch((e) => {
prStateStore.setPrError(branch.id, e instanceof Error ? e.message : String(e));
});
}

let prCompletionInFlight = false;
Expand Down Expand Up @@ -420,21 +423,24 @@
// Push
// =========================================================================

async function handlePush(force = false) {
function handlePush(force = false) {
if (pushState === 'pushing') return;

pushStateStore.setPushing(branch.id, '__pending__');

try {
const agents = isRemote ? REMOTE_AGENTS : agentState.providers;
const provider = getPreferredAgent(agents) ?? undefined;
const sessionId = await commands.pushBranch(branch.id, provider, force);
sessionRegistry.register(sessionId, branch.projectId, 'push', branch.id);
pushStateStore.setPushing(branch.id, sessionId);
projectStateStore.addRunningSession(branch.projectId, sessionId);
} catch (e) {
pushStateStore.setPushError(branch.id, e instanceof Error ? e.message : String(e));
}
const agents = isRemote ? REMOTE_AGENTS : agentState.providers;
const provider = getPreferredAgent(agents) ?? undefined;

commands
.pushBranch(branch.id, provider, force)
.then((sessionId) => {
sessionRegistry.register(sessionId, branch.projectId, 'push', branch.id);
pushStateStore.setPushing(branch.id, sessionId);
projectStateStore.addRunningSession(branch.projectId, sessionId);
})
.catch((e) => {
pushStateStore.setPushError(branch.id, e instanceof Error ? e.message : String(e));
});
}

let pushCompletionInFlight = false;
Expand Down Expand Up @@ -513,7 +519,7 @@
} else if (prState === 'created') {
const url = prUrl ?? cachedPrUrl;
if (url) {
commands.openUrl(url);
commands.openUrl(url).catch((e) => console.error('Failed to open PR URL:', e));
} else if (branch.prNumber) {
commands
.getPrUrl(branch.id, branch.prNumber)
Expand Down