refactor(git): stream bundles from temp files instead of buffering in memory#202
Draft
refactor(git): stream bundles from temp files instead of buffering in memory#202
Conversation
… memory createBundle now returns an open *os.File (already unlinked from the filesystem) instead of reading the entire bundle into a []byte. Callers stream directly from the fd and use io.MultiWriter to write to the HTTP response and S3 cache simultaneously. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d0383-345f-7659-8538-30bc7c9a7e6d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createBundlenow returns an open*os.File(already unlinked from the filesystem) instead of reading the entire bundle into a[]byte. Callers stream directly from the fd and useio.MultiWriterto write to the HTTP response and S3 cache simultaneously.Changes
createBundle: returns*os.Fileinstead of[]byte. The temp file is removed from the filesystem immediately after opening; the open fd keeps the data alive until the caller closes it.handleBundleRequest: streams from the file to both the HTTP response and S3 cache viaio.MultiWriter, replacing the previous write-then-cache-async pattern.serveSnapshotWithBundle: background goroutine streams from the file to S3 cache.cacheBundleAsync/cacheBundleSync, replaced with singlecacheBundle(ctx, key, io.Reader).strconvimport (no longer needed withoutContent-Lengthheader on bundles).