feat(desktop): persona & team improvements — channel indicators, async imports, team export/import#156
Open
wesbillman wants to merge 8 commits intomainfrom
Open
feat(desktop): persona & team improvements — channel indicators, async imports, team export/import#156wesbillman wants to merge 8 commits intomainfrom
wesbillman wants to merge 8 commits intomainfrom
Conversation
…rt backend Feature 1: Add agent-already-in-channel indicators - AddAgentToChannelDialog: fetch channel members, show 'Already a member' badge, contextual 'Re-add to channel' button text - AddChannelBotDialog: use new useInChannelPersonaIds hook to compute in-channel persona IDs, pass to PersonasSection and TeamsSection - AddChannelBotPersonasSection: show 'In channel' badge on persona chips - AddChannelBotTeamsSection: show per-team in-channel count and per-persona check marks in tooltip - New useInChannelPersonaIds hook extracts shared logic Refactor: extract shared normalizePubkey utility - New shared/lib/pubkey.ts with canonical normalizePubkey function - Deduplicate from channelAgents.ts, ChannelMembersBar.tsx, presence/hooks.ts, profile/lib/identity.ts, shared/lib/authors.ts Feature 3 (backend): team export/import Tauri commands - managed_agents/teams.rs: add encode_team_json, parse_team_json, types (TeamPersonaPreview, ParsedTeamPreview) with 10 unit tests - commands/teams.rs: add export_team_to_json (async, save dialog) and parse_team_file commands - Register new commands in lib.rs
Feature 2: Async import flow with loaders - PersonaDialog: parsing overlay with spinner, submit disabled during parse - BatchImportDialog: per-item status indicators (spinner/✓/✗) during import Feature 3 Frontend: Team export/import UI - TeamsSection: Export menu item + Import button with file picker - TeamImportDialog: full import dialog with per-persona progress tracking - tauriTeams.ts: exportTeamToJson + parseTeamFile API functions - useTeamActions: export/import/complete handlers extracted from AgentsView Rust refactors: - Extracted slugify() into shared util with 5 unit tests - Extracted save_json_with_dialog() into commands/export_util.rs - Deduplicated ~60 lines across persona and team export commands Fixes from review: - TeamImportDialog: disable Import button on error (prevents duplicate personas) - TeamImportDialog: use stable index-based React keys - Team creation auto-retries once on failure with clear error message
Deduplicate promptPreview() from PersonasSection, TeamImportDialog, and AddChannelBotPersonasSection into shared/lib/promptPreview.ts. Extract the Loader2/Check/X status icon pattern from BatchImportDialog and TeamImportDialog into shared/ui/import-status-icon.tsx with a reusable ImportStatusIcon component and ImportItemStatus type.
The dialog content could overflow its container when importing teams with many personas, pushing the footer buttons (Cancel / Import) below the visible area and making them unclickable. Fixes: - Add min-h-0 to flex container for proper CSS flex shrinking - Add shrink-0 to header and footer to prevent compression - Reduce max-h from 85vh to 80vh for more breathing room - Add min-h-0 to scrollable content area for flex overflow
…+ drop zone hints
wesbillman
force-pushed
the
feat/personas-improvements
branch
from
f0871ed to
c9d5ac9
Compare
Mirror the TeamsSection import pattern on PersonasSection: - Drag/drop overlay for .persona.json, .persona.png, or .zip files - Upload button (file picker) next to the Create button - Drop zone hint text in subtitle and empty state - handlePersonaImportFile in AgentsView routes single files to PersonaDialog and multi-file archives to BatchImportDialog Bump AgentsView.tsx file size limit from 740 to 790 to accommodate the new import handler wiring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three improvements to the agents/personas experience in the desktop app:
Feature 1: "Already in channel" indicators
AddAgentToChannelDialogshows "✓ Already a member" badge when the agent is already in the selected channel, with "Re-add to channel" button textAddChannelBotDialogshows "In channel" badges on persona chips and team cardsuseInChannelPersonaIdshook — properly gated, only fires when dialog is opennormalizePubkeyfunctions intoshared/lib/pubkey.tsFeature 2: Async import flow with loaders
PersonaDialog— spinner overlay during file parsing, submit disabled while parsingBatchImportDialog— per-item status indicators (⏳ spinner / ✓ done / ✗ error)Feature 3: Team import/export
export_team_to_json+parse_team_fileTauri commands with 10 unit testsslugify()+save_json_with_dialog()shared utils with 5 unit testsexportTeamToJson+parseTeamFileintauriTeams.tsCode quality
promptPreviewfunction (was duplicated in 3 files)ImportStatusIconcomponent (was duplicated in 2 files)Test Plan
cargo test -p sprout -- teamandcargo test -p sprout -- slugify(15 new tests)pnpm typecheckcleanpnpm checkclean